Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: fix OpenTelemetry exporter with multiple processors #3270

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

valerybugakov
Copy link
Member

Context

  • Currently, NodeSDK does not support multiple-span processors and exporters. This functionality was added three weeks ago and will be included in the following experimental release. To fix the problem without waiting for the release, I migrated this functionality to lower-level primitives, where we have complete control over the number of exporters.
  • Slack discussion

Test plan

  • Verified that traces are sent to the OTel collector via proxyman locally.
  • Verified that traces are logged to the console in the development mode.

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

@valerybugakov valerybugakov enabled auto-merge (squash) February 27, 2024 08:51
@valerybugakov valerybugakov enabled auto-merge (squash) February 27, 2024 08:52
@valerybugakov valerybugakov merged commit 734763f into main Feb 27, 2024
16 checks passed
@valerybugakov valerybugakov deleted the vb/fix-opentelemetry-exporter branch February 27, 2024 08:58
steveyegge pushed a commit that referenced this pull request Mar 13, 2024
…3270)

Currently, `NodeSDK` does not support multiple-span processors and exporters. This functionality [was added](open-telemetry/opentelemetry-js#4454) three weeks ago and will be included in [the following experimental release](open-telemetry/opentelemetry-js#4504). To fix the problem without waiting for the release, I migrated this functionality to lower-level primitives, where we have complete control over the number of exporters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants